Prefer Primer::Beta::Button
in ERBLint::Linters::ButtonComponentMigrationCounter
#1782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ERBLint::Linters::ButtonComponentMigrationCounter
currently asks people to replace raw HTML withPrimer::ButtonComponent
, butPrimer::ButtonComponent
is deprecated, which then results in another linter error asking forPrimer::ButtonComponent
to be replaced withPrimer::Beta::Button
.It seems to make more sense that
ERBLint::Linters::ButtonComponentMigrationCounter
just prefersPrimer::Beta::Button
?Integration
No.
Merge checklist